Wrong token ID in mintReserveAuction#

In Minting.sol there is mintReserveAuction function that is used for minting a canvas that was on reserve auction. On lines 588 - 591 and 593 - 596 we can see that the tokenId is assigned the value of count of token IDs and only after that, the count of token IDs is incremented. This would be okay if token IDs would start at 0. However, they start at 1, which can be seen in CanvasCollection.sol. This means that the traits and canvas ID will not match the token. It will also override the traits and canvas ID of the last minted token.

586
587
588
589
590
591
592
593
594
595
596
597

uint256 tokenId;
if (ds.canvasSystem[canvasId].isCurated) {
    ds.canvasOneCurated[ds.contractInfo.canvasOneCuratedCounter] = canvasId;
    tokenId = ds.contractInfo.canvasOneCuratedCounter;
    ds.customization[ds.contractInfo.canvasOneCuratedAddress][tokenId].selectedTraits = selectedTraits;
    unchecked { ds.contractInfo.canvasOneCuratedCounter++; }
} else {
    ds.canvasOne[ds.contractInfo.canvasOneCounter] = canvasId;
    tokenId = ds.contractInfo.canvasOneCounter;
    ds.customization[ds.contractInfo.canvasOneAddress][tokenId].selectedTraits = selectedTraits;
    unchecked { ds.contractInfo.canvasOneCounter++; }
}

Recommendation#

Change the code so that the token ID is equal to last token ID + 1. The solution was already included in ReserveAuction mints wrong canvas.